[fix] Fix map type mapping to doris type error #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JNSimba
reviewed
Dec 12, 2023
...nector/src/main/java/org/apache/doris/flink/deserialization/converter/DorisRowConverter.java
Outdated
Show resolved
Hide resolved
|
It is recommended to add map type coverage in DorisRowConverterTest |
Ok !!! |
DongLiang-0
reviewed
Dec 15, 2023
flink-doris-connector/src/test/java/org/apache/doris/flink/DorisSinkMapSQLExample.java
Outdated
Show resolved
Hide resolved
DongLiang-0
approved these changes
Dec 18, 2023
JNSimba
reviewed
Dec 19, 2023
...nector/src/main/java/org/apache/doris/flink/deserialization/converter/DorisRowConverter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When you map the flink Map<date, date> type to map<date, date> or map<string, string> in Doris, this will cause the key to be null and the result to be incorrect respectively. Therefore, it can be solved by converting the key in Map into Date.
second, it solves the problem of converting Map<TIMESTAMP_LTZ,TIMESTAMP_LTZ> into MAP<STRING,STRING> without time zone information.
We add a unit test for map type.
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...