Mysql testResource instead of devservices in FIPS #6658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldettinger
reviewed
Oct 18, 2024
...dbc/mysql/src/test/java/org/apache/camel/quarkus/component/jdbc/mysql/MysqlTestResource.java
Outdated
Show resolved
Hide resolved
|
I switched to draft as a different approach should be used. |
JiriOndrusek
force-pushed
the
mysql-fips-wip
branch
3 times, most recently
from
4064c1e
to
638b8f8
Compare
|
The behavior had to be changed, it is not possible to disable devservice from the TestResource. I kept the FIPS profile, which stops dev service. TestResource starts the container only in case of stopped devservice |
JiriOndrusek
force-pushed
the
mysql-fips-wip
branch
from
638b8f8
to
7de1fb0
Compare
JiriOndrusek
changed the title
JiriOndrusek
force-pushed
the
mysql-fips-wip
branch
from
7de1fb0
to
b9796a5
Compare
aldettinger
approved these changes
Oct 18, 2024
jamesnetherton
approved these changes
Oct 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6657
The FIPS testing is much more easier if simple test container is used.