Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44589: [GLib] Add GArrowDecimal32 class #44597

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

hiroyuki-sato
Copy link
Contributor

@hiroyuki-sato hiroyuki-sato commented Oct 31, 2024

Rationale for this change

The Decimal32 class has been introduced. It is necessary to support it in GLib.

What changes are included in this PR?

Implement GArrowDecimal32 class

Are these changes tested?

YES

Are there any user-facing changes?

NO

Copy link

⚠️ GitHub issue #44589 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit c23ee73 into apache:main Oct 31, 2024
10 checks passed
@kou kou removed the awaiting review Awaiting review label Oct 31, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 31, 2024
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit c23ee73.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

@hiroyuki-sato hiroyuki-sato deleted the topic/garrow-decimal32 branch November 1, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants