GH-44570: [Release][R][Docs] Update r/pkgdown/assets/versions.html
#44572
+61
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
requested review from
assignUser,
jonkeane,
raulcd and
thisisnic
as code owners
|
|
github-actions
bot
added
Component: R
awaiting committer review
kou
force-pushed
the
release-bump-versions-r
branch
from
aa004d7
to
34d5442
Compare
kou
force-pushed
the
release-bump-versions-r
branch
from
34d5442
to
999c1a1
Compare
jonkeane
approved these changes
Oct 31, 2024
| @@ -194,6 +194,7 @@ update_versions() { | |||
| "${base_version}" \ | |||
| "${next_version}" | |||
| git add docs/source/_static/versions.json | |||
| git add r/pkgdown/assets/versions.html | |||
There was a problem hiding this comment.
Aaah was this missing so we weren't actually updating that page? Oops!
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 191472d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It's still used at https://arrow.apache.org/docs/r/versions.html . So we should update it too.
What changes are included in this PR?
Commit it.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
r/pkgdown/assets/versions.htmlisn't updated #44570