GH-44564: [Java][FlightSQL] Fix native libraries relocation #44565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefix used by native libraries shipped in the JDBC driver do not match the prefix used by Netty `NativeLibraryLoader` class, preventing them to be detected and loaded. Change the prefix of the libraries and add a integration test to verify the libraries are loaded Also exclude several group of data which are not properly relocated and may cause conflict with existing classpath.
|
@github-actions crossbow submit -g java |
|
Revision: 16824ca Submitted crossbow builds: ursacomputing/crossbow @ actions-6b353f850c
|
|
@github-actions crossbow submit java-jars |
|
Revision: 16824ca Submitted crossbow builds: ursacomputing/crossbow @ actions-051991ec49
|
lidavidm
approved these changes
Oct 30, 2024
|
|
||
| /** Check that relocated netty code can also load matching native library. */ | ||
| @Test | ||
| @Timeout(value = 2, unit = TimeUnit.MINUTES) |
There was a problem hiding this comment.
Not really, I copied the pattern from the other test method (which also does not really need a test timeout as well)
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 3217fc2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Prefix used by native libraries shipped in the JDBC driver do not match the prefix used by Netty
NativeLibraryLoaderclass, preventing them to be detected and loaded.What changes are included in this PR?
Change the prefix of the libraries and add a integration test to verify the libraries are loaded
Also exclude several group of data which are not properly relocated and may cause conflict with existing classpath.
Are these changes tested?
Yes, new test added for checking the native library loader
Are there any user-facing changes?
No