Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [R] Trim news for 18.0 release #44562

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

nealrichardson
Copy link
Member

Rationale for this change

The referenced change was included in the 17.0.0.1 CRAN submission (#43317 (comment)) so we don't need to announce it here. As far as CRAN releases go, the performance regression was never released.

What changes are included in this PR?

rm

Are these changes tested?

🙅

Are there any user-facing changes?

Words

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Oct 29, 2024
@nealrichardson nealrichardson merged commit ea9b15f into apache:main Oct 29, 2024
11 checks passed
@nealrichardson nealrichardson deleted the trim-news-18.0 branch October 29, 2024 15:57
Copy link

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit ea9b15f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

amoeba pushed a commit that referenced this pull request Oct 30, 2024
### Rationale for this change

The referenced change was included in the 17.0.0.1 CRAN submission
(#43317 (comment))
so we don't need to announce it here. As far as CRAN releases go, the
performance regression was never released.

### What changes are included in this PR?

rm

### Are these changes tested?

🙅 

### Are there any user-facing changes?

Words
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants