GH-44101: [C++][Parquet] Tools: Debug Print for Json should be valid JSON #44532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
pitrou
approved these changes
Oct 25, 2024
cpp/src/parquet/reader_test.cc
Outdated
| @@ -1172,6 +1180,30 @@ TEST_F(TestJSONWithLocalFile, JSONOutputFLBA) { | |||
| EXPECT_THAT(json_content, testing::HasSubstr(json_contains)); | |||
| } | |||
|
|
|||
| // GH-44101: Test that JSON output is valid JSON | |||
| TEST_F(TestJSONWithLocalFile, ValidJsonOutput) { | |||
| auto checkJsonValid = [](std::string_view json_string) -> ::arrow::Status { | |||
github-actions
bot
added
awaiting committer review
|
https://github.com/apache/arrow/actions/runs/11514744258/job/32053979673?pr=44532 Emmm seems this is orc related, and unrelated to this patch? 🤔 |
|
@mapleFU The error message seems related, perhaps we need to make RapidJSON mandatory when Parquet tests are enabled? |
|
Aha, my bad, will fix this |
mapleFU
commented
Oct 26, 2024
| @@ -320,7 +320,7 @@ if(ARROW_TESTING) | |||
| # "link" our dependencies so that include paths are configured | |||
| # correctly | |||
| target_link_libraries(parquet_testing PUBLIC ${ARROW_GTEST_GMOCK}) | |||
| list(APPEND PARQUET_TEST_LINK_LIBS parquet_testing) | |||
| list(APPEND PARQUET_TEST_LINK_LIBS parquet_testing RapidJSON) | |||
There was a problem hiding this comment.
add rapidjson to PARQUET_TEST_LINK_LIBS, hope will not affect too much
kou
changed the title
wgtmac
approved these changes
Oct 28, 2024
|
Would merge this firstly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The printJson is not a valid json now. This is ok for human-read, but when I want to analysis it with json tools or ai, it will prevent from using it.
What changes are included in this PR?
Change the output to be a valid json.
Style:
previously, the
\"trailing would be added in start of object, but this patch put it to end of objectBefore:
After:
Are these changes tested?
Yes
Are there any user-facing changes?
Minor format change