Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44386: [Integration][Release] Pin Python 3.12 for Integration verification when using Conda #44388

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Oct 12, 2024

Rationale for this change

Conda Python 3.13 fails when running verification tasks for Java. It's related to JPype.

See also:

What changes are included in this PR?

Pin Python 3.12 on Conda integration jobs because JPype doesn't work with Python 3.13. We can use Python 3.13 again once JPype supports Python 3.13.

Are these changes tested?

Yes via CI

Are there any user-facing changes?

No

Copy link

⚠️ GitHub issue #44386 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 12, 2024
@raulcd
Copy link
Member Author

raulcd commented Oct 12, 2024

@github-actions crossbow submit verify-rc-source-integration-macos-conda-amd64

Copy link

Revision: bee940b

Submitted crossbow builds: ursacomputing/crossbow @ actions-c8cecf863c

Task Status
verify-rc-source-integration-macos-conda-amd64 GitHub Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 12, 2024
@raulcd raulcd marked this pull request as ready for review October 12, 2024 11:22
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Oct 12, 2024
@kou kou merged commit 8a7224d into apache:main Oct 12, 2024
6 checks passed
@kou kou removed the awaiting changes Awaiting changes label Oct 12, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8a7224d.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them.

raulcd added a commit that referenced this pull request Oct 13, 2024
…fication when using Conda (#44388)

### Rationale for this change

Conda Python 3.13 fails when running verification tasks for Java. It's related to JPype.

See also:
* GH-44389
* https://discuss.python.org/t/api-for-python-3-13-prevents-use-of-3rd-party-gc-allocators/62709/5

### What changes are included in this PR?

Pin Python 3.12 on Conda integration jobs because JPype doesn't work with Python 3.13. We can use Python 3.13 again once JPype supports Python 3.13.

### Are these changes tested?

Yes via CI

### Are there any user-facing changes?

No
* GitHub Issue: #44386

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants