Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44277: [CI] Use Miniforge instead of Mambaforge #44278

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Oct 1, 2024

@pitrou
Copy link
Member Author

pitrou commented Oct 1, 2024

@github-actions crossbow submit -g cpp -g python

@github-actions github-actions bot added the awaiting review Awaiting review label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

⚠️ GitHub issue #44277 has been automatically assigned in GitHub to PR creator.

Copy link

github-actions bot commented Oct 1, 2024

Revision: 4f775e7

Submitted crossbow builds: ursacomputing/crossbow @ actions-aa8c229567

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-cpp-ubuntu-20.04-cuda-11.2.2 GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-fedora-39-python-3 GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@pitrou
Copy link
Member Author

pitrou commented Oct 1, 2024

@github-actions crossbow submit -g conda

Copy link

github-actions bot commented Oct 1, 2024

Revision: 4f775e7

Submitted crossbow builds: ursacomputing/crossbow @ actions-2eb6ab5228

Task Status
conda-clean Azure
conda-linux-aarch64-cpu-py3 Azure
conda-linux-aarch64-cuda-py3 Azure
conda-linux-ppc64le-cpu-py3 Azure
conda-linux-ppc64le-cuda-py3 Azure
conda-linux-x64-cpu-py3 Azure
conda-linux-x64-cuda-py3 Azure
conda-osx-arm64-cpu-py3 Azure
conda-osx-x64-cpu-py3 Azure
conda-win-x64-cpu-py3 Azure
conda-win-x64-cuda-py3 Azure

@raulcd
Copy link
Member

raulcd commented Oct 1, 2024

We haven't been testing the conda-xxx jobs in a while as those are not up to date with upstream so those are not expected to work. I think we should take a decision whether we just remove them and let upstream conda deal with possible issues or someone takes de effort to update them.

@pitrou
Copy link
Member Author

pitrou commented Oct 1, 2024

Agreed, I didn't think they were in such a bad state.

@pitrou
Copy link
Member Author

pitrou commented Oct 1, 2024

@raulcd Is this PR ok to you?

@raulcd
Copy link
Member

raulcd commented Oct 1, 2024

@githbu-actions crossbow submit verify-rc-source-java-linux-conda-latest-amd64

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've validated locally some of the jobs forcing to rebuild (not caching intermediate docker) and works as expected. I'll wait for the archery job to finish before merging

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Oct 1, 2024
@raulcd
Copy link
Member

raulcd commented Oct 1, 2024

@github-actions crossbow submit verify-rc-source-java-linux-conda-latest-amd64

Copy link

github-actions bot commented Oct 1, 2024

Revision: 4f775e7

Submitted crossbow builds: ursacomputing/crossbow @ actions-8ea08b43f4

Task Status
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions

@raulcd raulcd merged commit 6863f50 into apache:main Oct 1, 2024
37 of 38 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Oct 1, 2024
@pitrou pitrou deleted the gh44277-miniforge branch October 1, 2024 13:22
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6863f50.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants