-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43846: [Python][Packaging] Remove numpy dependency from pyarrow packaging #44148
Conversation
|
@github-actions crossbow submit -g python |
Revision: 2a52bce Submitted crossbow builds: ursacomputing/crossbow @ actions-929cd4e6ac |
@github-actions crossbow submit -g wheel |
@github-actions crossbow submit verify-python |
Revision: 2a52bce Submitted crossbow builds: ursacomputing/crossbow @ actions-6a782cdfa6 |
Revision: 2a52bce Submitted crossbow builds: ursacomputing/crossbow @ actions-09c6d448ff |
@jorisvandenbossche is this something we want to do before 18.0.0? |
Should we bring that up on the mailing list? My guess is that it won't be that disruptive because most people will have numpy installed via other dependencies anyway, but it might be a bit hard to predict. |
Looks good! Can you update the documentation? https://arrow.apache.org/docs/dev/python/install.html#dependencies |
Thanks @jorisvandenbossche I've just updated the Numpy dependency from required to optional on the docs |
@jorisvandenbossche if you are ok with this I'll merge for 18.0.0 |
I am fine with that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…ckaging (#44148) ## WIP Creating the PR to validate if / what are the CI failures ### Rationale for this change Once the issue has been merged: - #25118 We do not require numpy as a pyarrow dependency. ### What changes are included in this PR? Remove numpy as a required dependency ### Are these changes tested? Via CI ### Are there any user-facing changes? Yes, pyarrow won't install numpy as a required dependency. * GitHub Issue: #43846 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8be5f9c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
With Arrow 18.0.0 numpy is not a dependency anymore: apache/arrow#44148 I think it would be good to also remove it from PyIceberg
With Arrow 18.0.0 numpy is not a dependency anymore: apache/arrow#44148 I think it would be good to also remove it from PyIceberg
* Remove numpy as a hard dependency With Arrow 18.0.0 numpy is not a dependency anymore: apache/arrow#44148 I think it would be good to also remove it from PyIceberg * Add link to issue
WIP
Creating the PR to validate if / what are the CI failures
Rationale for this change
Once the issue has been merged:
We do not require numpy as a pyarrow dependency.
What changes are included in this PR?
Remove numpy as a required dependency
Are these changes tested?
Via CI
Are there any user-facing changes?
Yes, pyarrow won't install numpy as a required dependency.