-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36078: [C#] Flight SQL implementation for C# #36079
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this. I don't know a whole lot about flight SQL so I'm probably not going to detect a missing message or command. I went through this and made a few questions I hope you can help me with.
csharp/src/Apache.Arrow.Flight/Server/Internal/FlightServerImplementation.cs
Outdated
Show resolved
Hide resolved
csharp/test/Apache.Arrow.Flight.Sql.Tests/FlightSqlProducerTests.cs
Outdated
Show resolved
Hide resolved
csharp/test/Apache.Arrow.Flight.Sql.Tests/FlightSqlProducerTests.cs
Outdated
Show resolved
Hide resolved
csharp/test/Apache.Arrow.Flight.Sql.Tests/FlightSqlProducerTests.cs
Outdated
Show resolved
Hide resolved
csharp/test/Apache.Arrow.Flight.Sql.Tests/FlightSqlProducerTests.cs
Outdated
Show resolved
Hide resolved
@westonpace bump just in case you may not have seen the request for re-review |
Thanks for the ping. For some reason I thought this had already merged. Thanks for addressing the feedback, I think this is good to go now. I've merged with main and will let CI run one more time. |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit be5ab86. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
Flight SQL implementation for C# that is compatible with the C++ and Java implementations. Closes issue apache#36078 * Closes: apache#36078 Lead-authored-by: Jeremy Osterhoudt <jeremy.osterhoudt@ge.com> Co-authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
Flight SQL implementation for C# that is compatible with the C++ and Java implementations.
Closes issue #36078