Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go/adbc/sqldriver): fix handling of decimal types #970

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

zeroshade
Copy link
Member

fixes #969

@zeroshade zeroshade requested a review from lidavidm August 8, 2023 16:48
@lidavidm lidavidm added this to the ADBC Libraries 0.6.0 milestone Aug 8, 2023
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the issue where the user didn't get an error for an unrecognized type?

@zeroshade
Copy link
Member Author

sure, let me dig a bit further into that

@zeroshade
Copy link
Member Author

So, as far as I can tell from my testing, the user didn't get an error because they didn't call the .Err method on the rows object to check, as per the usual pattern. I can't see any other situation, nor replicate a situation where the .Err doesn't return the error. So i don't think there's an issue to be fixed there.

@lidavidm
Copy link
Member

Should've used Rust 😉

LGTM then. Thanks!

@lidavidm lidavidm merged commit 653683e into apache:main Aug 15, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go flightsql driver with database/sql - rows.Next false when records exist with Decimal value
2 participants