fix(csharp/src/Drivers/Apache): fix float data type handling for tests on Databricks Spark #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s on Databricks Spark
birschick-bq
requested review from
lidavidm and
CurtHagenlocher
as code owners
| @@ -139,6 +139,13 @@ public override string GetInsertStatement(string tableName, string columnName, s | |||
| public override SampleDataBuilder GetSampleDataBuilder() | |||
| { | |||
| SampleDataBuilder sampleDataBuilder = new(); | |||
| Type floatNetType = ServerType == SparkServerType.Databricks ? typeof(float) : typeof(double); | |||
| Type floatArrowType = ServerType == SparkServerType.Databricks ? typeof(FloatType) : typeof(DoubleType); | |||
| object floatValue; | |||
There was a problem hiding this comment.
In principle, it probably should be float for both. I imagine the reason we get doubles via Thrift is that TColumn doesn't define a TFloatColumn, only a TDoubleColumn. But if we know from the schema that it should be a float then we should probably be doing a conversion in the driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the handling of
floatdata type when running the integration tests on Databricks Sparkcloses #2281