Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-26134]Resolve Test case failures in Ambari Metrics host Monitoring #133

Merged

Conversation

sandeep318kumar
Copy link
Contributor

[AMBARI-26134]Resolve Test case failures in Ambari Metrics host Monitoring

What changes were proposed in this pull request?

resolving all test failures for ambari-host-monitoring

(Please fill in changes proposed in this fix)

How was this patch tested?

Testing is pending.

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

@vishalsuvagia
Copy link

Testing is pending.
@sandeep318kumar , can you kindly update PR with the testing performed for the fix ?

@sandeep318kumar
Copy link
Contributor Author

sandeep318kumar commented Sep 24, 2024

Failed tests:
ERROR: TestEmitter (unittest.loader._FailedTest)

ImportError: Failed to import test module: TestEmitter
Traceback (most recent call last):
File "/home/runner/work/ambari-metrics/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py", line 27, in
import kerberos
ModuleNotFoundError: No module named 'kerberos'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/lib/python3.8/unittest/loader.py", line 154, in loadTestsFromName
module = import(module_name)
File "/home/runner/work/ambari-metrics/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py", line 30, in
from spnego_kerberos_auth import SPNEGOKerberosAuth
File "/home/runner/work/ambari-metrics/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py", line 29, in
from krberr import krberr as kerberos
ImportError: cannot import name 'krberr' from 'krberr' (/home/runner/work/ambari-metrics/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py)

CI is failing because we don't have kerberos module installed in CI environment.
We can install it using 'pip install kerberos'

@JiaLiangC any idea how to install this in CI setup?

@sandeep318kumar
Copy link
Contributor Author

@JiaLiangC @vishalsuvagia can you help in how to install kerberos module in CI setup?

@vishalsuvagia
Copy link

@JiaLiangC @vishalsuvagia can you help in how to install kerberos module in CI setup?

@skumar, can you kindly rebase the patch and update the test run flow for the same

@vishalsuvagia
Copy link

LGTM +1 from my side, @JiaLiangC would you like to review the fix ?

Copy link
Contributor

@arshadmohammad arshadmohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@arshadmohammad arshadmohammad merged commit 7f5b225 into apache:master Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants