Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layout): minor adjustment to layout config #545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DOD-101
Copy link
Contributor

@DOD-101 DOD-101 commented Aug 14, 2024

This addresses the first request in #535.

  1. Remove columns

The change is mainly in adjusting how the borders are drawn.

It doesn't address the second request:

Add different columns to replace them

It might also be a good idea to implement some guard clauses to prevent the unseen windows from being rendered etc.

This addresses the first request in aome510#535. The change is mainly in
adjusting how the borders are drawn.
@NickTheWilder
Copy link

NickTheWilder commented Aug 15, 2024

(New to rust so bear with me)

I'd like to test this since it's a feature I requested to at least contribute what I can. How could I do that?
Is there already a contributing/how-to-build-locally doc that I'm missing?

I run cargo b to build the application, and then cargo r to run and I get the errors:

image

Cargo version: cargo 1.80.1 (376290515 2024-07-16)
Git: 2.46.0 (latest version)

EDIT: figured it out, I had a bad config file

@DOD-101
Copy link
Contributor Author

DOD-101 commented Aug 16, 2024

That's strange. There shouldn't be any errors. (Especially since all the checks are passing)

Try running git diff / git status to see if something may have accidental changed.

Is there already a contributing/how-to-build-locally doc that I'm missing?

Not that I know of.

Tip: You can just run cargo r(un). It will build and then run.

Copy link
Owner

@aome510 aome510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think increasing other windows' size to "remove" a column is a good idea. The column is not really removed, it's just hidden from the UI. FocusNextWindow still points to the "hidden" window, which is confusing.

@DOD-101
Copy link
Contributor Author

DOD-101 commented Aug 18, 2024

Do you think we should have a separate config option for this, or do we have an internal check if any column has a width of 0 and then skip any code relating to?

I think the option of an internal check would be better, since it's less config for the user to write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants