Resolve issue #107 to restore network report demo #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 28, 2024 13:19
|
[commented out the IOS XE facts collection until I understand the issue] |
jce-redhat
requested changes
Aug 30, 2024
collections/ansible_collections/demo/patching/roles/build_report_network/tasks/main.yml
Show resolved
Hide resolved
Comment on lines
5
to
11
| # - name: Permit traffic in default zone for http service | ||
| # ansible.posix.firewalld: | ||
| # service: http | ||
| # permanent: true | ||
| # state: enabled | ||
| # immediate: true | ||
| # check_mode: false |
There was a problem hiding this comment.
same as above, delete vs. comment out
network/report.yml
Outdated
Comment on lines
23
to
27
| # - name: Gather all network resource and minimal legacy facts [Cisco IOS XR] | ||
| # cisco.iosxr.iosxr_facts: | ||
| # gather_subset: min | ||
| # gather_network_resources: all | ||
| # when: ansible_network_os == 'cisco.iosxr.iosxr' |
There was a problem hiding this comment.
same as above, delete vs. comment out
jce-redhat
reviewed
Aug 30, 2024
collections/ansible_collections/demo/patching/roles/build_report_network/tasks/main.yml
Show resolved
Hide resolved
taruch
changed the title
taruch
changed the title
taruch
changed the title
|
Requested changes made in commit f699741 |
jce-redhat
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue 107.
Fixes report through documentation (README.md updates) and playbook changes.