Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description and label to demo jt #15598

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions awx/main/management/commands/create_preload_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from django.core.management.base import BaseCommand
from django.db import transaction
from crum import impersonate
from awx.main.models import User, Organization, Project, Inventory, CredentialType, Credential, Host, JobTemplate
from awx.main.models import User, Organization, Project, Inventory, CredentialType, Credential, Host, JobTemplate, Label

Check warning on line 7 in awx/main/management/commands/create_preload_data.py

View check run for this annotation

Codecov / codecov/patch

awx/main/management/commands/create_preload_data.py#L7

Added line #L7 was not covered by tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRealHaoLiu could you document how you tested this change?

Codecov reveals that nothing in this module is ever hit in the test suite: https://app.codecov.io/gh/ansible/awx/pull/15598#f9e72d3f63929dd1c3c1d53def0b69c6-L7. So the CI wouldn't be able to catch any regressions.

from awx.main.signals import disable_computed_fields


Expand Down Expand Up @@ -50,9 +50,11 @@

ssh_type = CredentialType.objects.filter(namespace='ssh').first()
c, _ = Credential.objects.get_or_create(
credential_type=ssh_type, name='Demo Credential', inputs={'username': getattr(superuser, 'username', 'null')}, created_by=superuser
credential_type=ssh_type,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a formatting-only change? I don't see any difference.

name='Demo Credential',
inputs={'username': getattr(superuser, 'username', 'null')},
created_by=superuser,
)

if superuser:
c.admin_role.members.add(superuser)

Expand All @@ -73,15 +75,28 @@
created_by=superuser,
)

label, _ = Label.objects.get_or_create(organization=o, name='demo')

Check warning on line 78 in awx/main/management/commands/create_preload_data.py

View check run for this annotation

Codecov / codecov/patch

awx/main/management/commands/create_preload_data.py#L78

Added line #L78 was not covered by tests

jt_description = (

Check warning on line 80 in awx/main/management/commands/create_preload_data.py

View check run for this annotation

Codecov / codecov/patch

awx/main/management/commands/create_preload_data.py#L80

Added line #L80 was not covered by tests
"This template serves as a quick introduction to how Ansible Automation works. "
"It runs a basic automation task, allowing you to see Ansible in action without "
"needing to set up anything complex. You can use this template to understand "
"how job templates operate and test how Ansible interacts with systems in a "
"simple, safe environment."
)
jt = JobTemplate.objects.filter(name='Demo Job Template').first()
if jt:
jt.project = p
jt.description = jt_description

Check warning on line 90 in awx/main/management/commands/create_preload_data.py

View check run for this annotation

Codecov / codecov/patch

awx/main/management/commands/create_preload_data.py#L90

Added line #L90 was not covered by tests
jt.inventory = i
jt.playbook = 'hello_world.yml'
jt.save()
else:
jt, _ = JobTemplate.objects.get_or_create(name='Demo Job Template', playbook='hello_world.yml', project=p, inventory=i)
jt, _ = JobTemplate.objects.get_or_create(

Check warning on line 95 in awx/main/management/commands/create_preload_data.py

View check run for this annotation

Codecov / codecov/patch

awx/main/management/commands/create_preload_data.py#L95

Added line #L95 was not covered by tests
name='Demo Job Template', description=jt_description, playbook='hello_world.yml', project=p, inventory=i
)
jt.credentials.add(c)
jt.labels.add(label)

Check warning on line 99 in awx/main/management/commands/create_preload_data.py

View check run for this annotation

Codecov / codecov/patch

awx/main/management/commands/create_preload_data.py#L99

Added line #L99 was not covered by tests

print('Default organization added.')
print('Demo Credential, Inventory, and Job Template added.')
Expand Down
Loading