Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Add support for playbook adjacent collections #511

Merged
merged 32 commits into from
Jul 12, 2023

Conversation

priyamsahoo
Copy link
Contributor

@priyamsahoo priyamsahoo commented Dec 2, 2022

The PR adds support for playbook adjacent collections.
Resolves: #123, ansible/vscode-ansible#631

@priyamsahoo priyamsahoo added the enhancement New feature or request label Dec 2, 2022
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from minor formatting comments, the overall PR looks good to me.

@priyamsahoo priyamsahoo force-pushed the playbook-adjacent-collection branch 6 times, most recently from 7eaef06 to 8d9b7b3 Compare January 24, 2023 10:27
@priyamsahoo priyamsahoo changed the title [WIP] Add support for playbook adjacent collections Add support for playbook adjacent collections Feb 22, 2023
@priyamsahoo priyamsahoo marked this pull request as ready for review February 22, 2023 17:21
@priyamsahoo priyamsahoo requested a review from a team as a code owner February 22, 2023 17:21
Taskfile.yml Outdated Show resolved Hide resolved
docs/settings.md Outdated Show resolved Hide resolved
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can merge after the minor comments are fixed.

change setting name from supportPlaybookAdjacentCollections to usePlaybookAdjacentCollections
@priyamsahoo
Copy link
Contributor Author

On the 13th Feb's weekly meeting, We decided that we do not need to add a setting for supporting playbook adjacent collections since Ansible, by default, provides the support for it.
Therefore, I am entirely removing the setting supportAdjacentPlaybookCollections.

@audgirka audgirka merged commit 0800741 into ansible:main Jul 12, 2023
9 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 14, 2023
## v1.2.0

### Minor Changes

- Add support for playbook adjacent collections (#511) @priyamsahoo
- Use antsibull-docs-ts to render semantic markup (#563) @felixfontein

### Bugfixes

- Fix isPlaybook method (#590) @priyamsahoo
- Fix vars completion in task files (#589) @priyamsahoo
- Return URI instead of filepath (#560) @ajinkyau
@ansibot ansibot mentioned this pull request Jul 14, 2023
ansibot added a commit that referenced this pull request Jul 14, 2023
## v1.2.0

### Minor Changes

- Add support for playbook adjacent collections (#511) @priyamsahoo
- Use antsibull-docs-ts to render semantic markup (#563) @felixfontein

### Bugfixes

- Fix isPlaybook method (#590) @priyamsahoo
- Fix vars completion in task files (#589) @priyamsahoo
- Return URI instead of filepath (#560) @ajinkyau

Co-authored-by: Ansible DevTools <ansible-devtools@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to allow auto-completion and diagnostics for playbook adjacent collections
3 participants