This repository has been archived by the owner on Oct 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 91
Add support for playbook adjacent collections #511
Merged
audgirka
merged 32 commits into
ansible:main
from
priyamsahoo:playbook-adjacent-collection
Jul 12, 2023
Merged
Add support for playbook adjacent collections #511
audgirka
merged 32 commits into
ansible:main
from
priyamsahoo:playbook-adjacent-collection
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyamsahoo
force-pushed
the
playbook-adjacent-collection
branch
from
December 4, 2022 07:20
802f103
to
92622f7
Compare
ganeshrn
reviewed
Dec 27, 2022
ganeshrn
reviewed
Dec 27, 2022
ganeshrn
reviewed
Dec 27, 2022
ganeshrn
approved these changes
Dec 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from minor formatting comments, the overall PR looks good to me.
…/ansible-language-server into playbook-adjacent-collection
priyamsahoo
force-pushed
the
playbook-adjacent-collection
branch
6 times, most recently
from
January 24, 2023 10:27
7eaef06
to
8d9b7b3
Compare
… rather than inside ansibleConfig
priyamsahoo
changed the title
[WIP] Add support for playbook adjacent collections
Add support for playbook adjacent collections
Feb 22, 2023
ganeshrn
reviewed
Jul 5, 2023
ganeshrn
reviewed
Jul 5, 2023
ganeshrn
reviewed
Jul 5, 2023
ganeshrn
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can merge after the minor comments are fixed.
change setting name from supportPlaybookAdjacentCollections to usePlaybookAdjacentCollections
On the 13th Feb's weekly meeting, We decided that we do not need to add a setting for supporting playbook adjacent collections since Ansible, by default, provides the support for it. |
…rovide support for it by default
audgirka
approved these changes
Jul 12, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
## v1.2.0 ### Minor Changes - Add support for playbook adjacent collections (#511) @priyamsahoo - Use antsibull-docs-ts to render semantic markup (#563) @felixfontein ### Bugfixes - Fix isPlaybook method (#590) @priyamsahoo - Fix vars completion in task files (#589) @priyamsahoo - Return URI instead of filepath (#560) @ajinkyau
Merged
ansibot
added a commit
that referenced
this pull request
Jul 14, 2023
## v1.2.0 ### Minor Changes - Add support for playbook adjacent collections (#511) @priyamsahoo - Use antsibull-docs-ts to render semantic markup (#563) @felixfontein ### Bugfixes - Fix isPlaybook method (#590) @priyamsahoo - Fix vars completion in task files (#589) @priyamsahoo - Return URI instead of filepath (#560) @ajinkyau Co-authored-by: Ansible DevTools <ansible-devtools@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for playbook adjacent collections.
Resolves: #123, ansible/vscode-ansible#631