-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: typo in handler name and loop item handling in when statement #71
Bugfix: typo in handler name and loop item handling in when statement #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
hi @MarcoV-git Thank you for taking the time to investigate the issue and raise the PR.
many thanks uk-bolly |
Hi @uk-bolly , My bad! Will fix it tomorrow. Cheers, |
Updated to be compliant |
0e6c7df
to
8c32d14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find and thank you for the PR
My git log shows that I have signed both my commits. I do see an unsigned commit from you: commit 8921431 (upstream/devel, upstream/HEAD, origin/devel, devel)
|
- Fixed typo in handler name Signed-off-by: Marco V <marco@osp.nl>
Signed-off-by: Marco V <marco@osp.nl>
Signed-off-by: Marco V <marco@osp.nl>
68720bf
to
69813b5
Compare
@uk-bolly Finally fixed the pull |
Tested in:
ansible [core 2.14.7]
config file = /Users/xxxxx/ansible.cfg
configured module search path = ['/Users/xxxxx/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/lib/python3.11/site-packages/ansible
ansible collection location = /Users/xxxxx/.ansible/collections:/usr/share/ansible/collections
executable location = /usr/local/bin/ansible
python version = 3.11.4 (main, Jun 20 2023, 16:59:59) [Clang 14.0.3 (clang-1403.0.22.14.1)] (/usr/local/opt/python@3.11/bin/python3.11)
jinja version = 3.1.2
libyaml = True