Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siemens/feat/4.2.1.3conditional and section header #143

Conversation

ipruteanu-sie
Copy link
Contributor

Overall Review of Changes:
rsyslog refactoring

Issue Fixes:
#141
#142

Enhancements:
Please list any enhancements/features that are not open issue tickets

How has this been tested?:
N/A

…ad of 4.2.1. rsyslog name)

Signed-off-by: Ionut Pruteanu <ionut.pruteanu@siemens.com>
…el9cis_syslog == 'rsyslog'`, having same condition is redundant and may confuse users.

Signed-off-by: Ionut Pruteanu <ionut.pruteanu@siemens.com>
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix

@uk-bolly uk-bolly merged commit 6f8a95c into ansible-lockdown:devel Dec 21, 2023
4 checks passed
@uk-bolly uk-bolly mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants