Updated RHEL-08-020050 to loop over stdout_lines. Fixes issue #261. #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @Phenix66 This is a great catch in the rhel8-stig, thank you for taking the time to raise the issue and subsequent PR. We are happy to accept this fix but unfortunately have noted that the PR is not signed-off-by or gpg signed ( -s -S in a commit). We do require all commits are signed in this way before we are able to accept them. Many thanks uk-bolly |
SeanathanVT
suggested changes
Mar 20, 2024
…-lockdown#261. Signed-off-by: Phenix66 <34311559+Phenix66@users.noreply.github.com>
|
Commit should be GPG signed now |
SeanathanVT
approved these changes
Mar 21, 2024
uk-bolly
approved these changes
Mar 21, 2024
uk-bolly
approved these changes
Mar 21, 2024
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Using
stdout_lineswill ensure that the looped variable is always a list, even with a single entry.Issue Fixes:
#261
Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?:
Mocked scenarios locally