-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stig v1r12 into devel #256
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
commit 14d7da6a3335dea85d73044cac45f851d45e721f Author: Mark Bolwell <mark.bollyuk@gmail.com> Date: Wed Feb 21 15:52:45 2024 +0000 updated Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> commit e6b8a7c2008da9cf11075265801723c597284d6e Author: Mark Bolwell <mark.bollyuk@gmail.com> Date: Wed Feb 21 15:52:05 2024 +0000 lint and variable improvements Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> commit 79948fb314df745bc37f94dffcdf6ec818d945bc Author: Mark Bolwell <mark.bollyuk@gmail.com> Date: Wed Feb 21 15:51:32 2024 +0000 ssh validation added Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> commit 4742d58286387ffdbf569c2094d34290c8f2f90a Author: Mark Bolwell <mark.bollyuk@gmail.com> Date: Wed Feb 21 15:50:46 2024 +0000 ssh validation added Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> commit 33348bc1d3a0537d0cdbcfc70c10286875d97261 Author: Mark Bolwell <mark.bollyuk@gmail.com> Date: Wed Feb 21 15:50:25 2024 +0000 changed ordering and added logic Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> commit 6c2d07987d379575c6ecf766e528da19ba5ffae0 Author: Mark Bolwell <mark.bollyuk@gmail.com> Date: Wed Feb 21 15:50:12 2024 +0000 removed as mnot required Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> commit 1d775c698c9270f707dddbd955d096bfaa978dae Author: Mark Bolwell <mark.bollyuk@gmail.com> Date: Wed Feb 21 15:50:04 2024 +0000 updated Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> commit 562d7604e5263ed4d5cd97cdd2a46ea4a1c3f58f Author: Mark Bolwell <mark.bollyuk@gmail.com> Date: Wed Feb 21 15:49:57 2024 +0000 updated precommit Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> commit bb46131304f00cfe9c9b7b62dda9150ab5d19643 Author: Mark Bolwell <mark.bollyuk@gmail.com> Date: Wed Feb 21 12:04:15 2024 +0000 Added ability for audit_only Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com> Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: uk-bolly <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
georgenalen
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Release Stig v1r12 to community
Issues
#245
#248
#254
Enhancements:
Audit updates
Several improvements
How has this been tested?:
Manually with audit only and new audit
manually with full remediation and audit
"msg": [
"The pre remediation results are: Count: 867, Failed: 428, Skipped: 31, Duration: 8.732s.",
"The post remediation results are: Count: 867, Failed: 38, Skipped: 19, Duration: 120.083s.",
"Full breakdown can be found in /opt",