Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenStack - Improve connection check after instance creation #231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathias-ioki
Copy link

The Wait for SSH task in the create.yml playbook makes some assumptions:

  • ansible host is always directly accessible from the control node
  • port 22 is always used for connection

Both of them are not always true, especially the first one. Especially in cloud environments a bastion node / jumphost is used very often to connect to the VMs. Such a scenario can't be used with the current implementation.

Therefore I would suggest to move this task to the prepare.yml playbook. We can use wait_for_connection then, which respects the ssh config (jumphost, ports, ...) and the ansible config for these hosts. So both described use cases are now possible.

This can break existing configurations, if the prepare.yml is overridden within the actual molecule test.

Copy link

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant