Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm selenium, combine renderer1,2,3 #144

Merged
merged 6 commits into from
Aug 28, 2024
Merged

rm selenium, combine renderer1,2,3 #144

merged 6 commits into from
Aug 28, 2024

Conversation

tdhock
Copy link
Collaborator

@tdhock tdhock commented Aug 27, 2024

hi @siddhesh195
this is a follow-up to #126

  • removed RSelenium in testthat.R and DESCRIPTION
  • run only one renderer CI job instead of three

DESCRIPTION Show resolved Hide resolved
@tdhock
Copy link
Collaborator Author

tdhock commented Aug 27, 2024

looks like build is working now with renderer tests all combined into a single CI job, and with Selenium removed.
Do you see any other places in the code where we could remove selenium?

@tdhock tdhock merged commit 84eff9b into master Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants