Skip to content
This repository has been archived by the owner on May 28, 2019. It is now read-only.

fix(date): Apply the ui-date-format to the dateOptions if provided #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexanderchan
Copy link
Contributor

Fixes #120

@alexanderchan
Copy link
Contributor Author

Alas, there isn't a team for ui-date, just myself, and I am trying to find the difference between chrome and Firefox that causes this problem or a way to resolve it in a different way. Any suggestions are welcome on how to rewrite this to work for at least ff and chrome.

@ivan-zakharchuk
Copy link

Let me look deeper into this problem. Because I'm a bit don't like try-catch construction and hope we can avoid this. BTW(this PR doesn't work in my case unfortunately)

@alexanderchan
Copy link
Contributor Author

Fantastic thanks, yah let's try to improve it. Wish I had more time to work
on it but now that I'm not using it in production (or even angular) it has
been more challenging.
On Mon, Mar 28, 2016 at 09:26 Ivan Zakharchuk notifications@github.com
wrote:

Let me look deeper into this problem. Because I'm a bit don't like
try-catch construction and hope we can avoid this. BTW(this PR doesn't work
in my case unfortunately)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#159 (comment)

@ivan-zakharchuk
Copy link

Hi, just want to keep you updated that I'm still working on this.

@alexanderchan
Copy link
Contributor Author

Thanks for the update, no rush, I probably won't be able to merge until the
2nd week of April. Thanks for taking this on!

On Wed, Mar 30, 2016 at 11:17 AM Ivan Zakharchuk notifications@github.com
wrote:

Hi, just want to keep you updated that I'm still working on this.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#159 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants