Bug 12 #13
Open
Bug 12 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d files This change allows clients (such as XHR requests) to obtain the total size of the served file, e.g. to display a progress bar. One caveat that applies is that the HTTP spec does not define if Content-Length refers to the compressed or uncompressed content. Here, we arbitrarily pick the compressed content (body length verbatim), as it is the most readily-available measure for the client.
You should still enable github integration in Travis UI
Mime 2.x deleted charset support, as it isn't very useful now (almost everyone has moved to UTF-8). So we can either delete the charset header or use a different library which does provide the charset API. Closes andrewrk#12
|
Could someone agree on this commit and release it on master ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains 3 changes:
travis.ymlso bugs like this are prevented in the future