Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove golang.org/x/exp since it doesn't follow go 1 compatibility promise #957

Closed
wants to merge 1 commit into from

Conversation

trim21
Copy link

@trim21 trim21 commented Jun 30, 2024

document says golang.org/x/exp doesn't follow go 1 compatibility promise, so copy the package we used to internal for future compatibility promise.

In the future if downsteam user import exp with a newer non-compatibility version it will get unexpected surprise.

it's still a indirect dependency from github.com/anacrolix/generics, so I suggest to remove it from github.com/anacrolix/generics too

@anacrolix
Copy link
Owner

I'm really not that worried about it. If exp removes the APIs, it still won't break people unless they're aggressively updating their transitive dependencies (a common anti-pattern in Go, go get -u specifically).

That said, the Go team has been known to remove APIs for pedantic reasons, but it's still not that worrying.

@trim21
Copy link
Author

trim21 commented Jul 4, 2024

downstream users may rely on another package non-compatibility exp versions in the future

@trim21
Copy link
Author

trim21 commented Jul 15, 2024

go1.23 will add these 2 functions to stdlib

@anacrolix
Copy link
Owner

Awesome, feel free to make a PR to use the functions from the standard library

@anacrolix anacrolix closed this in e5ae1f0 Sep 29, 2024
@anacrolix
Copy link
Owner

I fixed this in master, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants