Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native Unicode font on Window & macOS, ignore missing stopword file #219

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DKWoods
Copy link

@DKWoods DKWoods commented Jan 12, 2017

I've modified FONT_PATH so it seeks a font on Windows and macOS that supports Unicode characters, such as Chinese and Arabic. If this fails, or if you are on Linux, it falls back to the DroidSansMono font.

Also, if the default stopwords file is missing, the program creates an empty set. (I didn't want default stopwords, and py2exe on Windows didn't copy the stopwords file.)

@amueller
Copy link
Owner

It seems like a good idea to default to a unicode enabled font. What do you think about shipping a different open source font? That might be more robust than what you did. I'm not familiar enough with windows to know on how many different versions this works.

@amueller
Copy link
Owner

Noto Sans seems like a good candidate: https://www.google.com/get/noto/

@DKWoods
Copy link
Author

DKWoods commented Jan 12, 2017 via email

@DKWoods
Copy link
Author

DKWoods commented Jan 12, 2017 via email

@DKWoods
Copy link
Author

DKWoods commented Jan 12, 2017 via email

@amueller
Copy link
Owner

@DKWoods
Copy link
Author

DKWoods commented Jan 12, 2017 via email

@amueller
Copy link
Owner

thanks for trying! I'll come back to this in a bit, I'm crazy swamped right now!

@DKWoods
Copy link
Author

DKWoods commented Feb 2, 2017 via email

@amueller
Copy link
Owner

amueller commented Feb 3, 2017

Hey David. Sorry I didn't follow up on your patch - it's on my todo list, but my todo list is long.
I have no idea about the py2exe error you're encountering. I'm not a Windows user and I have no experience with creating stand-along executables, sorry.
Good luck!

Andy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants