Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial SysTray PR #48

Closed
wants to merge 50 commits into from
Closed

initial SysTray PR #48

wants to merge 50 commits into from

Conversation

conlan0
Copy link
Contributor

@conlan0 conlan0 commented Apr 3, 2024

  • This is windows support only
  • Added system tray icon with support for a menu with links and dividers and the support for submenus with links
  • Agent gets a nats signal every 5 mins to restart and update systray icon, name and config
  • Agent runs the systray on startup

@wh1te909 wh1te909 marked this pull request as draft April 3, 2024 21:52
Copy link
Member

@wh1te909 wh1te909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the failing tests we need to ensure the windows only stuff lives in files named something_windows.go and then stub the functions for linux/mac. You can stub them in agent_unix.go

@conlan0
Copy link
Contributor Author

conlan0 commented Apr 3, 2024

To fix the failing tests we need to ensure the windows only stuff lives in files named something_windows.go and then stub the functions for linux/mac. You can stub them in agent_unix.go

got that done but i think theirs an issue where i import support in main.go here

'case "tray":

	if runtime.GOOS == "windows" {
		support.InitTrayIcon()
	}`

@wh1te909
Copy link
Member

wh1te909 commented Apr 3, 2024

I don't see any stubs. Look at

// windows only below TODO add into stub file
and you'll need to stub all the new systray related windows

@conlan0
Copy link
Contributor Author

conlan0 commented Apr 4, 2024

okay got it. how do i update its packages now?

@wh1te909
Copy link
Member

wh1te909 commented Apr 4, 2024

You need to also add your go.mod and go.sum changes, I don't see those updated. When you installed that systray package on your local machine it would have updated these 2 files.

@conlan0
Copy link
Contributor Author

conlan0 commented Apr 4, 2024

now its getting the download errors i do lol

agent/support/main.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
agent/systray_windows.go Outdated Show resolved Hide resolved
agent/systray_windows.go Outdated Show resolved Hide resolved
@conlan0 conlan0 requested a review from wh1te909 August 5, 2024 21:33
@conlan0 conlan0 closed this by deleting the head repository Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants