Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds writers for range-based constraints #290

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

popematt
Copy link
Contributor

@popematt popematt commented Oct 3, 2023

Issue #, if available:
None

Description of changes:

  • Adds helper function for writing DiscreteIntRanges
  • Adds ConstraintWriter impl for all *_length constraints as well as precision and exponent.
  • Adds tests for the constraint writers

Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt requested a review from desaikd October 3, 2023 19:25
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...hema/writer/internal/constraints/ExponentWriter.kt 0.00% <0.00%> (ø)
...ema/writer/internal/constraints/PrecisionWriter.kt 0.00% <0.00%> (ø)
...lin/com/amazon/ionschema/writer/internal/ranges.kt 0.00% <0.00%> (ø)
...er/internal/constraints/LengthConstraintsWriter.kt 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

@popematt popematt merged commit 7f1ce92 into amazon-ion:master Oct 3, 2023
3 of 5 checks passed
@popematt popematt deleted the writer-part-2 branch June 13, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants