Adds implementations of repeat, make_field, and make_blob #972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
make_field
,make_blob
andrepeat
.make_field
andrepeat
need to be able to track some state over their evaluation, so I added a field toExpansionInfo
thatExpanders
can use for that purpose rather than having to create a pool of variousExpander
instances.MacroEvaluator
, updatedMakeStringExpander
andMakeSymbolExpander
to not acceptnull
, as per the spec.MacroEvaluatorTest
, updated comments to have the(%x)
syntax for argument expansion.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.