Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ion 1.1 system symbols #939

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

popematt
Copy link
Contributor

Issue #, if available:

None.

Description of changes:

This adds an implementation of Ion 1.1 Symbols. Rather than try to kludge them into the existing SymbolToken interface, my plan is to treat them like a special case of symbols with inline text.

Also updates OpCode 0xEE to mean "system symbol" so that we're not sharing EF between system symbols and system macros because that was unnecessarily complicated to implement, and we didn't know if it was going to be a macro or a symbol until we read the second byte.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt changed the title Adds Ion 1.1 system symbol table Adds Ion 1.1 system symbols Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 11.90476% with 74 lines in your changes missing coverage. Please review.

Please upload report for BASE (ion-11-encoding@047e37a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...main/java/com/amazon/ion/impl/SystemSymbols_1_1.kt 0.00% 73 Missing ⚠️
src/main/java/com/amazon/ion/impl/IonTypeID.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             ion-11-encoding     #939   +/-   ##
==================================================
  Coverage                   ?   69.82%           
  Complexity                 ?     6798           
==================================================
  Files                      ?      194           
  Lines                      ?    26955           
  Branches                   ?     4882           
==================================================
  Hits                       ?    18821           
  Misses                     ?     6635           
  Partials                   ?     1499           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zslayton zslayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some superficial comments to consider before merging below.

src/main/java/com/amazon/ion/impl/IonTypeID.java Outdated Show resolved Hide resolved
src/main/java/com/amazon/ion/impl/SystemSymbols_1_1.kt Outdated Show resolved Hide resolved
@popematt popematt merged commit d380bf0 into amazon-ion:ion-11-encoding Sep 19, 2024
22 of 36 checks passed
@popematt popematt deleted the system-symbols-a branch September 19, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants