Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Arty S7 25 and 50 mains. #244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Split Arty S7 25 and 50 mains. #244

wants to merge 1 commit into from

Conversation

calder
Copy link

@calder calder commented Apr 25, 2024 •
edited
Loading

Before

Running

python3 -m amaranth_boards.arty_s7

defaults to S7 25. When run against an S7 50 the flashing process succeeds, but the LEDs never turn on.

After

The user has to explicitly specify an S7 version with:

python3 -m amaranth_boards.arty_s7_25

or

python3 -m amaranth_boards.arty_s7_50

Both ArtyS7_25Platform and ArtyS7_50Platform are still available for import from amaranth_boards.arty_s7.

@wanda-phi
Copy link
Member

The general approach taken in amaranth-boards is to make the exact platform variant a command-line argument to main instead — see machxo3_sk.py for an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calder @wanda-phi