Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community/php7-pecl-apcu: Fix build against PHP 7.3 #5901

Closed
wants to merge 1 commit into from
Closed

community/php7-pecl-apcu: Fix build against PHP 7.3 #5901

wants to merge 1 commit into from

Conversation

bratkartoffel
Copy link
Contributor

When building against PHP 7.3.0 the build fails due to missing pcre2
headers. This commit adds this dependency.

In file included from /aports/community/php7-pecl-apcu/src/apcu-5.1.16/apc_iterator.h:27,
                 from /aports/community/php7-pecl-apcu/src/apcu-5.1.16/php_apc.c:34:
/usr/include/php7/ext/pcre/php_pcre.h:27:10: fatal error: pcre2.h: No such file or directory
 #include "pcre2.h"
          ^~~~~~~~~
compilation terminated.
make: *** [Makefile:202: php_apc.lo] Error 1

Relates to #5863

@andypost andypost added S-hold Must not be merged now for some reason A-fix Fixes an abuild C-php labels Dec 24, 2018
@stale
Copy link

stale bot commented Mar 3, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be automatically closed if no further activity occurs in the next 14 days. If you are still waiting for a review or response from one of our developers you can leave a comment to remove the stale label. If you know the username of the maintainer of the aport you could try to mention the username in the comment. You can also join our IRC channels on freenode and see if you can find an available developer. Thank you for your contributions.

@stale stale bot added the S-stale label Mar 3, 2019
@@ -4,13 +4,13 @@ pkgname=php7-pecl-apcu
_pkgreal=apcu
# release 5 is php7+
pkgver=5.1.16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pkgver=5.1.16
pkgver=5.1.17

@stale stale bot removed S-stale labels Mar 10, 2019
@andypost
Copy link
Contributor

The reason behind this pr is fix s/pcre/pcre2 and bump pkgrel, not the version https://pecl.php.net/package-changelog.php?package=APCu&release=5.1.17

@TBK
Copy link
Contributor

TBK commented May 23, 2019

@andypost status?

When building against PHP 7.3.0 the build fails due to missing pcre2
headers. This commit adds this dependency.
@probot-autolabeler probot-autolabeler bot added the R-community Community repository label May 24, 2019
@bratkartoffel
Copy link
Contributor Author

outdated

@bratkartoffel bratkartoffel deleted the community/php7-pecl-apcu_fix-php-7.3 branch June 14, 2019 11:58
@TBK
Copy link
Contributor

TBK commented Jun 14, 2019

Merged with commit f34b568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-fix Fixes an abuild C-php R-community Community repository S-hold Must not be merged now for some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants