Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eips): Indexed Blob Hash #1526

Merged
merged 3 commits into from
Oct 24, 2024
Merged

feat(eips): Indexed Blob Hash #1526

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04e5e6c
feat: indexed blob hash
refcell Oct 18, 2024
09d4fd0
Merge branch 'main' into rf/feat/indexed-blob-hash
refcell Oct 22, 2024
3f317e3
Merge branch 'main' into rf/feat/indexed-blob-hash
refcell Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions crates/eips/src/eip4844/sidecar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,16 @@ use alloc::vec::Vec;
#[cfg(feature = "kzg")]
pub(crate) const VERSIONED_HASH_VERSION_KZG: u8 = 0x01;

/// A Blob hash
#[derive(Clone, Debug, Default, PartialEq, Eq, Hash)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct IndexedBlobHash {
/// The index of the blob
pub index: u64,
/// The hash of the blob
pub hash: B256,
}

/// This represents a set of blobs, and its corresponding commitments and proofs.
///
/// This type encodes and decodes the fields without an rlp header.
Expand Down Expand Up @@ -115,9 +125,12 @@ impl BlobTransactionSidecarItem {
result.then_some(()).ok_or(BlobTransactionValidationError::InvalidProof)
}

/// Verify the blob sidecar against its [crate::NumHash].
pub fn verify_blob(&self, hash: &crate::NumHash) -> Result<(), BlobTransactionValidationError> {
if self.index != hash.number {
/// Verify the blob sidecar against its [IndexedBlobHash].
pub fn verify_blob(
&self,
hash: &IndexedBlobHash,
) -> Result<(), BlobTransactionValidationError> {
if self.index != hash.index {
let blob_hash_part = B256::from_slice(&self.blob[0..32]);
return Err(BlobTransactionValidationError::WrongVersionedHash {
have: blob_hash_part,
Expand Down