fix: remove Clone from nonce-related APIs

[Daniel-Aaron-Bloom]

This is technically a breaking change as it modifies the public signatures of multiple traits and structs (removing clone, switching to self by value instead of reference), but it should have minimal impact on most downstream users.

Motivation

tl;dr is cloning a NonceManager (particularly CachedNonceManager because DashMap is not an Arc) is a big foot gun. It's actually even worse than that because the various layers automatically clone stuff on your behalf. The why is because cloning often turns numbers that should only be used once into numbers that are used twice.

Solution

Remove Clone from the relevant APIs, and patch up other APIs to remove their dependency on clonability of TxFillers. This does result in some duplicate ProviderLayer impls (by-ref and by-val).

PR Checklist

• Added Tests Not applicable
• Added Documentation Not applicable
• Breaking changes

[mattsse]

I see, unsure how we missed this

can we instead replace this with an Arc mutex instead? not a fan of dashmap anyway

[Daniel-Aaron-Bloom]

From a technical standpoint, yes, that would be possible. However, I would recommend against it as it's preserving the footgun for any external NonceManager implementations downstream crates may make.

[Daniel-Aaron-Bloom]

Also you wouldn't need to Arc<Mutex<_>>, just Arc<DashMap<_, _>> would be sufficient.

[mattsse]

this change we could do immediately, not sure I fully get the other parts of the pr yet, so I suggest to submit that separately

[Daniel-Aaron-Bloom]

The rest of the PR is just the minimal changes to fix all the errors from removing Clone.

This PR starts by removing Clone from CachedNonceManager, SimpleNonceManager, and NonceManager.

This means none of them fulfill TxFiller until we remove Clone from that (and replace it with Sized since it still needs that).

Doing that breaks the ProviderLayer implementation for JoinFill so we change that to move self instead of cloning &self.

That of course requires changing the signature of ProviderLayer::layer itself, which then requires changing all the impl ProviderLayers.

The duplicate &'a impls are just back-compat for anything which needs to call layer by reference.