Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signer-ledger): use SIGN_ETH_EIP_712 instruction #1479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Karrq
Copy link

@Karrq Karrq commented Oct 14, 2024

Motivation

Signing EIP712 messages thru alloy_network::TxSigner's sign_transaction results in the usage of SIGN instruction which does not support EIP712 messages.

Solution

Detect if the incoming tx is indeed a EIP712 transaction and dispatch to the appropriate method

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that familiar with this api

wdyt @DaniPopes

@DaniPopes
Copy link
Member

There's no such thing as a EIP-712 transaction, nor does any of the existing transaction ever return EIP-712-encoded data, so I don't know what this is trying to accomplish.

@DaniPopes
Copy link
Member

Nevermind, apparently there is #142
Please add a comment for this
cc @prestwich

@Karrq
Copy link
Author

Karrq commented Oct 15, 2024

This allows foundry-zksync to sign transactions using ledger, since we make use of sign_transaction to sign the encoded eip712 transacion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants