Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): subscribe to new blocks if possible in heartbeat #1321

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 20, 2024

Ref #1318

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best reviewed with "hide whitespace"; this is just moving async move to async fn

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,
ptal @yash-atreya

@DaniPopes DaniPopes merged commit f370156 into main Sep 23, 2024
26 checks passed
@DaniPopes DaniPopes deleted the dani/heartbeat-subscription branch September 23, 2024 20:10
lwedge99 pushed a commit to sentioxyz/alloy that referenced this pull request Oct 8, 2024
…oy-rs#1321)

* feat(provider): subscribe to new blocks if possible in heartbeat

* msg

* wasm

* fix

* move into stream

* feat: lazily subscribe to newHeads

* chore: remove async from get_heart

* testname
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants