Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define TransactionRespConstructor #1316

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Define TransactionRespConstructor #1316

wants to merge 5 commits into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Sep 19, 2024 •
edited
Loading

Motivation

Ref #1315.

Integration into reth, and integration of op-alloy into reth.

Requires at least paradigmxyz/reth#10750

Solution

Adds constructor to TransactionResponse trait, without loss of generality.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@emhane emhane added the debt Tech debt which needs to be addressed label Sep 19, 2024
@emhane emhane requested a review from klkvr September 23, 2024 12:31
@emhane emhane mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@klkvr klkvr Awaiting requested review from klkvr

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
debt Tech debt which needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emhane