run unit test on current change (#137)

* run unit test on current change
alibaba · Oct 24, 2024 · 36d61b5 · 36d61b5
1 parent 9c7c30f
commit 36d61b5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/unit_test.yml b/.github/workflows/unit_test.yml
@@ -2,8 +2,7 @@ name: Unit Tests
 
 on: 
   workflow_dispatch:
-  pull_request_target:
-    types: [opened, synchronize, reopened]
+  pull_request:
     branches:
       - main
       - dev
@@ -28,7 +27,7 @@ jobs:
     steps:
 
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Run unit test
       run: |
@@ -39,4 +38,4 @@ jobs:
         docker pull $UT_IMAGE
         docker run -v $PWD:$PWD -w $PWD --name chatlearn_ut_$(date '+%d_%m_%Y_%H_%M_%S') --net host --ipc host --shm-size 80G -t --rm --gpus all $UT_IMAGE bash -c 'make test'
       env: 
-        UT_IMAGE: ${{ secrets.UT_IMAGE }}
+        UT_IMAGE: registry.cn-wulanchabu.aliyuncs.com/pai-dlc/pytorch-training:2.4.0-gpu-py3.10-cu12.5-ngc24.06-ubuntu22.04
diff --git a/tests/run_tests.sh b/tests/run_tests.sh
@@ -62,8 +62,8 @@ function run_test {
 
 
 function run_all_tests {
-  run_test python test_rlhf_data_input.py -c "configs/exp.yaml"
   run_test python test_data_dp.py -c "configs/rlhf.yaml"
+  run_test python test_rlhf_data_input.py -c "configs/exp.yaml"
   run_test python test_data_dp_zero.py -c "configs/rlhf.yaml"
   run_test python test_rlhf_colocate_forward_train.py -c "configs/rlhf2.yaml"
   run_test python test_evaluator_multi.py -c "configs/test_eval2.yaml"