Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ruby): add more retry error details #3384

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Conversation

otomatik
Copy link
Contributor

@otomatik otomatik commented Jul 18, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DASH-1649

Changes included:

  • adding more details when raising an exception after last retry end in error state

🧪 Test

Tested in this similar PR: algolia/algoliasearch-client-ruby#501

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 18, 2024

✔️ Code generated!

Name Link
🪓 Triggered by c54fd06d75dcfa194db20ea00bbdd466b96d9df3
🍃 Generated commit 1765a00cde7b4503f788c0c8f71e8ea42112d844
🌲 Generated branch generated/fix/retry-error-ruby-client
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
ruby 874

@millotp millotp changed the title fix(error): add more retry error details fix(ruby): add more retry error details Jul 18, 2024
@otomatik otomatik self-assigned this Jul 18, 2024
Copy link

github-actions bot commented Jul 18, 2024

kombucha
kombucha previously approved these changes Jul 22, 2024
Copy link
Contributor

@kombucha kombucha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@otomatik otomatik force-pushed the fix/retry-error-ruby-client branch from f70c4f0 to 5bd2870 Compare July 23, 2024 11:48
@otomatik otomatik marked this pull request as ready for review July 23, 2024 12:29
@otomatik otomatik requested a review from a team as a code owner July 23, 2024 12:29
@millotp millotp merged commit b0fa5a9 into main Jul 23, 2024
12 checks passed
@millotp millotp deleted the fix/retry-error-ruby-client branch July 23, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants