Fix 337 #338
Merged
Fix 337 #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #338 +/- ##
=======================================
Coverage 98.70% 98.71%
=======================================
Files 28 28
Lines 1860 1864 +4
Branches 402 404 +2
=======================================
+ Hits 1836 1840 +4
Misses 2 2
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Merged
orbeckst
requested changes
Jan 3, 2024
| @@ -363,6 +363,15 @@ def _prepare_input(df, series, drop_duplicates, sort): | |||
| series : Series | |||
| Formatted Series. | |||
| """ | |||
| if series is None: | |||
| logger.warning( | |||
There was a problem hiding this comment.
I think we also should raise a real warning
warnings.warn(...)in addition to logging one.
|
|
||
|
|
||
| def test_series_none(dHdl, caplog): | ||
| statistical_inefficiency(dHdl, series=None) |
There was a problem hiding this comment.
Also test with pytest.warns(), see above.
orbeckst
approved these changes
Jan 3, 2024
|
@xiki-tempula looks good as it is but if you want to add the logger back then please do. Please squash-merge whenever you're ready. |
…an-error-when-not-given-series
xiki-tempula
deleted the
337-statistical_inefficiency-should-raise-an-error-when-not-given-series
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noneforstatistical_inefficiencydfandseriesforstatistical_inefficiencydoesn't have the same length