Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check booleans as well #37

Merged
merged 1 commit into from
Jul 19, 2023
Merged

test: check booleans as well #37

merged 1 commit into from
Jul 19, 2023

Conversation

agilgur5
Copy link
Owner

Summary

Add a boolean to the test store

Details

@agilgur5
test: check booleans as well
cca1c10 
- so all the most basic primitives are covered now (string, number, boolean)
  - checks against an issue report as well
@agilgur5 agilgur5 added scope: tests kind: internal Changes only affect the internal API labels Jul 19, 2023
@codecov

This comment was marked as resolved.

Sign in to view
agilgur5
agilgur5 commented Jul 19, 2023
View reviewed changes
Copy link
Owner Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. tiny change. tests pass.

@agilgur5 agilgur5 merged commit 1e2af1f into main Jul 19, 2023
14 checks passed
@agilgur5 agilgur5 deleted the test-bool branch July 19, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind: internal Changes only affect the internal API scope: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@agilgur5