add path to endpoint.ex in installation guide for Phoenix 1.7
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added clarification for newbies (like me) on where (endpoint) to enable Router Helpers so that kaffy works in Phoenix 1.7
|
This is usually not in |
aesmail
requested changes
Sep 18, 2023
| @@ -145,6 +145,7 @@ Follow the instructions at https://hexdocs.pm/phoenix_view/Phoenix.View.html | |||
|
|
|||
| You will also need to change `helpers: false` to `true` as shown in example below. | |||
| ```elixir | |||
| # in your lib/you_app_web/endpoint.ex | |||
There was a problem hiding this comment.
Great addition! Don't know how the filename wasn't mentioned here!
Just to be consistent with the rest of the docs, since we're using "my app" instead of "your app", could you please make this lib/my_app_web.ex and it'll be ready to merge.
|
Can we fix this up again and I'll merge. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clarification for newbies (like me) on where (endpoint) to enable Router Helpers so that kaffy works in Phoenix 1.7