-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multiplexing config #97
feat: add multiplexing config #97
Conversation
woluohenga
commented
Feb 23, 2023
- add ProtocolConfig, put codec in it
- add open_multiplexing config
Signed-off-by: woluohenga <tzh0813@qq.com>
2ed4aea
to
2ecb7b9
Compare
This PR is the API for #93 |
// The codec which encodes and decodes the application protocol. | ||
Codec codec = 1; | ||
// is open multiplexing | ||
bool open_multiplexing = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just multiplexing is clear enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@@ -151,3 +154,10 @@ message Tracing { | |||
envoy.config.trace.v3.Tracing.Http provider = 9; | |||
} | |||
|
|||
message ProtocolConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking that we name it ApplicationProtocol and put all configuration about the application protocol in it.
Please also add comment to application_protocol and codec to decalare these two fields have been deprecated. |
Signed-off-by: woluohenga <tzh0813@qq.com>
@@ -33,6 +33,7 @@ message MetaProtocolProxy { | |||
string stat_prefix = 1 [(validate.rules).string = {min_len: 1}]; | |||
|
|||
// The name of the application protocol built on top of meta protocol. | |||
// this field has been deprecated, now use protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been deprecated in favor of name in application_protocol.
@@ -46,6 +47,7 @@ message MetaProtocolProxy { | |||
} | |||
|
|||
// The codec which encodes and decodes the application protocol. | |||
// this field has been deprecated, now use protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been deprecated in favor of codec in application_protocol.
Signed-off-by: woluohenga <tzh0813@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM