-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user controls for title field visibility #3197
Open
glorenzen
wants to merge
266
commits into
advplyr:master
Choose a base branch
from
glorenzen:enhancement/title-field-visibility
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add user controls for title field visibility #3197
glorenzen
wants to merge
266
commits into
advplyr:master
from
glorenzen:enhancement/title-field-visibility
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glorenzen
force-pushed
the
enhancement/title-field-visibility
branch
from
August 3, 2024 17:13
6d865f1
to
39c26d2
Compare
Currently translated at 100.0% (853 of 853 strings) Translation: Audiobookshelf/Abs Web Client Translate-URL: https://hosted.weblate.org/projects/audiobookshelf/abs-web-client/de/
Currently translated at 100.0% (853 of 853 strings) Translation: Audiobookshelf/Abs Web Client Translate-URL: https://hosted.weblate.org/projects/audiobookshelf/abs-web-client/es/
…bs-web-client Translations update from Hosted Weblate
`unicode.so` is dynamically linked against glibc but Alpine only comes with musl. Installing the compatibility layer fixes it. Fix advplyr#3231 Fix advplyr#3234 Close advplyr#3235
…o-load Fix unicode.so loading
Currently translated at 100.0% (853 of 853 strings) Translation: Audiobookshelf/Abs Web Client Translate-URL: https://hosted.weblate.org/projects/audiobookshelf/abs-web-client/de/
Currently translated at 99.7% (851 of 853 strings) Translation: Audiobookshelf/Abs Web Client Translate-URL: https://hosted.weblate.org/projects/audiobookshelf/abs-web-client/fr/
Currently translated at 100.0% (853 of 853 strings) Translation: Audiobookshelf/Abs Web Client Translate-URL: https://hosted.weblate.org/projects/audiobookshelf/abs-web-client/zh_Hans/
…bs-web-client Translations update from Hosted Weblate
Additional logging for single file downloads coming from download function
standardizing log messages for all download cases
glorenzen
changed the title
WIP: Add user controls for title field visibility
Add user controls for title field visibility
Aug 6, 2024
Currently translated at 100.0% (974 of 974 strings) Translation: Audiobookshelf/Abs Web Client Translate-URL: https://hosted.weblate.org/projects/audiobookshelf/abs-web-client/fr/
Currently translated at 89.6% (873 of 974 strings) Translation: Audiobookshelf/Abs Web Client Translate-URL: https://hosted.weblate.org/projects/audiobookshelf/abs-web-client/it/
Currently translated at 100.0% (974 of 974 strings) Translation: Audiobookshelf/Abs Web Client Translate-URL: https://hosted.weblate.org/projects/audiobookshelf/abs-web-client/hr/
Currently translated at 100.0% (974 of 974 strings) Translation: Audiobookshelf/Abs Web Client Translate-URL: https://hosted.weblate.org/projects/audiobookshelf/abs-web-client/ru/
Currently translated at 92.8% (904 of 974 strings) Translation: Audiobookshelf/Abs Web Client Translate-URL: https://hosted.weblate.org/projects/audiobookshelf/abs-web-client/it/
Currently translated at 100.0% (974 of 974 strings) Translation: Audiobookshelf/Abs Web Client Translate-URL: https://hosted.weblate.org/projects/audiobookshelf/abs-web-client/hr/
…bs-web-client Translations update from Hosted Weblate
…-catch Catch file extraction errors in parseComicMetadata
added postcssOptions to remove npm warning
Move to node-unrar-js for cbr and node-stream-zip for cbz
…race-condition Change PlaybackSession createFromOld to use upsert instead of create
…~0 duration chapters advplyr#3361
…nzen/audiobookshelf into enhancement/title-field-visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add new options for users, allowing them to toggle field visibility for titles, such as publish year, publisher, etc. The options will be available on a modal that can be toggled from a context menu on a new toolbar on the item pages.
So far, I have added some UI components, such as the modal with the settings. I will add the functionality for the user settings soon.
This resolves #3055
Here are a couple of mockups I put together for it: