Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Release v2.19.0 #353

Open
wants to merge 145 commits into
base: develop
Choose a base branch
from
Open

Prepare Release v2.19.0 #353

wants to merge 145 commits into from

Conversation

jwaspin
Copy link
Contributor

@jwaspin jwaspin commented Mar 14, 2024

Closes #142
Closes #222
Closes #243
Closes #240
Closes #249
Closes #255
Closes #289
Closes #260
Closes #291
Closes #292
Closes #293
Closes #294
Closes #303
Closes #304
Closes #305
Closes #314
Closes #323
Closes #320

Might close the following:

#145
#257

Testing

Track testing deployment state here

https://dev-mdtranslator.mdeditor.org/

Changes

Version 2.19.0 (beta.31)

  • Fixed unit tests
  • New GitHub action to run tests

Dependencies

  • mdJson-schemas updated to version 2.9.5
  • mdCodes updated to version 2.10.0
  • nokogiri updated to version 1.15

Internal Object

  • New newRangeElementDescription
  • New newQualityResultFile
  • Fixed newCoverageResult
  • Fixed newDataQualityReport
  • Fixed newStandaloneReport

Readers

fgdc

  • Fixed the existing data quality reports implementation
  • Renamed module_quality to module_dataQuality
  • Disabling keywords requirement
  • Refactored lineage / methodology / process handler

mdJson

  • Fixed version unit test
  • Fixed & Completed Data Quality
    • Fixed & Completed Results (Conformance, Coverage, Descriptive, Qualitative)
    • Fixed reference to standaloneReport in the internal object (the reader and internal object were not aligned)
    • Fixed & Completed Quality Measure
    • New module_qualityResultFile
  • Fixed order of legal / use constraints
  • Fixed rangeElementDescription typo rangeElements -> rangeElement

sbJson

  • External Contact Identifiers
    • Restricted to "person" contact type
    • Looks for orcId and maps to externalIdentifiers[ { identifier: <orcId value>, namespace: "ORCID", description: "Open Researcher and Contributor Id" } ]

Writers

fgdc

  • Renamed class_quality to class_dataQuality
  • Fixed and Completed data quality to match changes in reader

html

  • Added "Quality" to the navigation list of links
  • Fixed & Completed Data Quality
    • New dataQualityReport class
    • New resultFile class
  • Fixed rangeElements -> rangeElement typo
  • Fixed :class syntax errors

iso19115-3

  • Added distribution->liabilityStatement to the legal constraints
  • Fixed & Completed Data Quality
    • Added Missing Fields
    • Fixed:
      • quality measure
      • evaluation method
      • descriptive result
      • quantitative result
    • Added:
      • conformance result
      • coverage result
      • quality result file
  • Fixed rangeElements -> rangeElement typo
  • Fixed date / datetime handling
  • Removed duplicate code (class_organization)
  • Added extended section with conditional to only write out if taxonomy exists
  • Modified time period to print the date based on precision

mdJson

  • Fixed ordering in modules:
    • allocation
    • data quality
    • funding
    • legal constraint
    • metadata (data quality was at the bottom, should be after resourceInfo)
  • Fixed & Completed Data Quality
    • New coverageResult module
    • Fixed & Completed Quality Measure
    • New qualityResultFile
    • New standaloneQualityReport (this was done incorrectly and none of the actual implementation was done)
  • Fixed and added some checks for nil and empty

sbJson

  • Refactored citation to use otherDetails if present, otherwise only include authors and title
  • External Contact Identifiers
    • Restricted to "person" contact type
    • Looks for external identifier with namespace "ORCID" and maps the associated identifier to orcId

simple-html

  • Added support for external contact identifiers
  • Added support for Data Quality
    • New dataQualityReport section
    • New resultFile section
  • Fixed rangeElement -> rangeElement typo
  • Fixed :class syntax errors
  • Fixed headers
  • Fixed links
  • Removed map
  • Re-enabled scope extents (not sure why it was commented out here and not in the html writer)
  • Bug fixes
    • fixed div that should be h5 (or other header tags)
    • fixed other details in citation
  • Enhancements
    • Links
    • Headers
    • Map

Fixed Unit Tests

  • In the mdJson_hash_functions helpers for the tests
    • Fixed the alphabetized ordering for build_dataQuality
    • Fixed the ordering of the build_dataQuality output
  • In the mdJson_hash_objects helpers for the tests
    • Fixed ordering of components
    • Fixed rangeElements -> rangeElement typo
    • Fixed dataQuality object

reader - fgdc

  • Fixed and added more assertions to lineage test
  • Removed a couple process tests
  • Fixed horizontal accuracy test (data quality)

reader - iso19115-3

  • Fixed id assertion
  • Fixed date / datetime test data

writer - mdJson

  • Fixed order of data quality in metadata object
  • New test runner for simple-html
  • Initial test data for simple-html

jwaspin and others added 30 commits November 15, 2023 16:23
Reader and writer.
Reader looks for orcId and maps to external identifier.
Writer looks for external identifier with namespace ORCID and maps associated id to orcId.
Both only work for contact type of person, disabled for organizations.
Add Reports Section
* fix key retrieval for Html_RangeElementDescription writer class

* fix br in rangeElement
@jwaspin jwaspin marked this pull request as ready for review May 26, 2024 19:11
@jwaspin jwaspin changed the title Release v2.19.0 Prepare Release v2.19.0 May 26, 2024
@jwaspin jwaspin changed the title Prepare Release v2.19.0 Prepare Beta Release v2.19.0 May 26, 2024
@jwaspin jwaspin changed the title Prepare Beta Release v2.19.0 Prepare Release v2.19.0 May 26, 2024
@jwaspin jwaspin requested a review from dwalt May 28, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment