Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing boards for CP 8.2.9 plus more Adafruit links #1301

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Add missing boards for CP 8.2.9 plus more Adafruit links #1301

merged 3 commits into from
Dec 11, 2023

Conversation

makermelissa
Copy link
Contributor

No description provided.

@makermelissa makermelissa requested a review from a team December 11, 2023 18:10
dhalbert
dhalbert reviewed Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the WisdPi boards, the description says "Introducing our...", which might be confused as something from Adafruit? Or do we have plenty of text like that? Could be made third-person instead of first-person?

I wonder if these descriptions might link to the originals. Then we could have a link at the top "From ".

@makermelissa
Copy link
Contributor Author

I generally try and change text like that, so I just updated it.

dhalbert
dhalbert requested changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wisdpi_tiny_rp2040.md needs a little copyediting to remove first-person references. It's also quite redundant: for instance the additional WS2812 RGB LED is mentioned three times (!).

I started to propose suggestions, but it got out of hand :)

@makermelissa
Copy link
Contributor Author

Yeah, I had copied and pasted from their website. I just revised most of it and updated.

dhalbert
dhalbert approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleanining up the copy.

@dhalbert dhalbert merged commit 0e44173 into adafruit:main Dec 11, 2023
3 checks passed
@dhalbert
Copy link
Collaborator

The multiple links for boards is working out great! Thanks for adding that.

@makermelissa
Copy link
Contributor Author

You're welcome. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makermelissa @dhalbert