-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename and add missing key to the keys list #966
Rename and add missing key to the keys list #966
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The pipeline is failing because of some invalid i18n keys, I can fix them in this PR if that's okay, @andrewtavis? |
Sure thing, makes sense, @jennethydyrova! :) Please do fix them as directed by the errors. Means that the refactoring we recently did worked out :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate you keeping up with the localization upkeep, @jennethydyrova! Would be interested in getting your feedback on the progress. Let me know if you think some things should be changed or if we can improve the process somehow 😊
Contributor checklist
Description
components.meta-tag-video.view-vide
tocomponents.card_search_result.view_video
to match new naming convention.Related issue