-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: copy url and redirect to signal when share link is clicked #955
feat: copy url and redirect to signal when share link is clicked #955
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@andrewtavis Hi, I've fixed the comments that you listed yesterday. Please let me know if any changes are needed. Also, I've closed the previous PR but I don't know if you want it to be deleted or not. Thanks! |
Hey @UnknownSean8! The idea of maybe a toast to that says that Signal is going to open is a good one 😊 Let's maybe not include it in here, but have a separate issue that implements this for all the share functionality that needs it? Would you want to work on that? I could make the issue :) |
Sounds like a good idea! I would be happy to work on it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really really nice, @UnknownSean8! Let's maybe change the Copied
to URL copied
, but I'll do that in the keys :) Will make the issue for the toasts now!
Contributor checklist
Description
This is the same PR from the other signal additional PR. I have a problem with my git so I had to recreate the branch.
For the implementation, I feel like there is still improvement that can be made, especially with the duplicated copy URL code. Feel free to let me know if there are any ideas/comments.
Also, just an idea, maybe we could add in a "Redirecting to Signal" infobox or something to let the user know that it is redirecting to signal.
Related issue