Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy url and redirect to signal when share link is clicked #955

Merged

Conversation

UnknownSean8
Copy link
Contributor

@UnknownSean8 UnknownSean8 commented Aug 31, 2024

Contributor checklist


Description

This is the same PR from the other signal additional PR. I have a problem with my git so I had to recreate the branch.

For the implementation, I feel like there is still improvement that can be made, especially with the duplicated copy URL code. Feel free to let me know if there are any ideas/comments.

Also, just an idea, maybe we could add in a "Redirecting to Signal" infobox or something to let the user know that it is redirecting to signal.

Related issue

Copy link
Contributor

github-actions bot commented Aug 31, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Aug 31, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 004cffe
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/66d2f493d89cc900087b7f5b
😎 Deploy Preview https://deploy-preview-955--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@UnknownSean8
Copy link
Contributor Author

UnknownSean8 commented Aug 31, 2024

@andrewtavis Hi, I've fixed the comments that you listed yesterday. Please let me know if any changes are needed. Also, I've closed the previous PR but I don't know if you want it to be deleted or not. Thanks!

@andrewtavis andrewtavis self-requested a review August 31, 2024 12:55
@andrewtavis
Copy link
Member

Hey @UnknownSean8! The idea of maybe a toast to that says that Signal is going to open is a good one 😊 Let's maybe not include it in here, but have a separate issue that implements this for all the share functionality that needs it? Would you want to work on that? I could make the issue :)

@UnknownSean8
Copy link
Contributor Author

Sounds like a good idea! I would be happy to work on it. Thanks!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really really nice, @UnknownSean8! Let's maybe change the Copied to URL copied, but I'll do that in the keys :) Will make the issue for the toasts now!

@andrewtavis andrewtavis merged commit 4810139 into activist-org:main Aug 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants